New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "notify slaves after dnsupdate was processed" #5321

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
2 participants
@mind04
Contributor

mind04 commented May 13, 2017

This reverts commit 89033f9.

Short description

The description for "slave-renotify" is "If we should send out notifications for slaved updates". Rfc2136 zones are by definition type 'MASTER' or 'NATIVE'. Using an option designed for slave zones to trigger a notify after a dnsupdate is confusing and may lead to unwanted side affects.

This pull also remove a duplicate include and an unnecessary extern CommunicatorClass Communicator; line.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis merged commit 9d084b6 into PowerDNS:master May 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mind04 mind04 deleted the mind04:dnsupdate branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment