Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add an optional action to `addDynBlocks()` #5337

Merged
merged 1 commit into from May 25, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented May 23, 2017

Short description

This allows using different actions for different blocks, refusing some and dropping others.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone May 23, 2017
@neilcook
Copy link
Contributor

@neilcook neilcook commented May 23, 2017

The README.md change doesn't include the new action in the example:

* `addDynBlocks(addresses, message[, seconds])`: block the set of addresses with message `msg`, for `seconds` seconds (10 by default), applying `action` (default to the one set with `setDynBlocksAction()`)

should be:

* `addDynBlocks(addresses, message[, seconds, [action]])`: block the set of addresses with message `msg`, for `seconds` seconds (10 by default), applying `action` (default to the one set with `setDynBlocksAction()`)
This allows using different actions for different blocks, refusing
some and dropping others.
@rgacogne rgacogne force-pushed the rgacogne:dnsdist-action-per-dynblock branch from 573f212 to 7b92543 May 23, 2017
@pieterlexis pieterlexis merged commit 18444e2 into PowerDNS:master May 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-action-per-dynblock branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.