New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calidns: add --increment and --want-recursion flags #5339

Merged
merged 6 commits into from Jun 2, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented May 23, 2017

Short description

This will allow using e.g. a stable amount of QPS (--increment 1) and test recursors.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@Habbie

How about using boost program options?

Show outdated Hide outdated pdns/calidns.cc Outdated
Show outdated Hide outdated pdns/calidns.cc Outdated
Show outdated Hide outdated pdns/calidns.cc Outdated
Show outdated Hide outdated pdns/calidns.cc Outdated
@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Jun 1, 2017

Member

@Habbie can you re-review?

Member

pieterlexis commented Jun 1, 2017

@Habbie can you re-review?

@Habbie

ok after these items

Show outdated Hide outdated pdns/calidns.cc Outdated
By default, this is 1.1.
--want-recursion
: Set this flag to send queries with the Recursion Desired flag set.

This comment has been minimized.

@Habbie

Habbie Jun 1, 2017

Member

initial-qps missing here?

@Habbie

Habbie Jun 1, 2017

Member

initial-qps missing here?

This comment has been minimized.

@pieterlexis

pieterlexis Jun 1, 2017

Member

initial-qps is not a flag but a positional option

@pieterlexis

pieterlexis Jun 1, 2017

Member

initial-qps is not a flag but a positional option

This comment has been minimized.

@Habbie

Habbie Jun 1, 2017

Member

oh yes

@Habbie

Habbie Jun 1, 2017

Member

oh yes

Show outdated Hide outdated pdns/calidns.cc Outdated

@pieterlexis pieterlexis merged commit c96911b into PowerDNS:master Jun 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:calidns-additions branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment