New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Print useful messages when query and response actions are mixed #5342

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 24, 2017

Short description

Print a friendly error message if you pass a DNSResponseAction to addRule(), or a DNSAction to addResponseRule() instead of a cryptic error.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone May 24, 2017

@pieterlexis pieterlexis merged commit 30e2593 into PowerDNS:master May 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-action-types branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment