New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add an optional interface parameter to addLocal()/setLocal() #5344

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 25, 2017

Short description

This might come in handy in VRF environments. Barely tested, but should not have any adverse effects.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone May 25, 2017

@ahupowerdns

I was pondering further additions to addLocal() and I think it is high time that we feed it a table like newServer(). This will come in handy with IP_TRANSPARENT options too. It is too much to add as parameters. So I would suggest redoing addLocal so it accepts a table which takes TCP options, reuseport, fast open and now interface as fields.

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-bin-itf branch from 2304d87 to efd35aa May 29, 2017

@rgacogne

This comment has been minimized.

Member

rgacogne commented May 29, 2017

I just pushed a commit moving {add,set}Local() additional parameters to a table.

@ahupowerdns

nice!

@ahupowerdns ahupowerdns merged commit 69314e6 into PowerDNS:master May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-bin-itf branch May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment