New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuaJIT 2.1: Lua fallback functionality no longer uses Lua namespace #5349

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@ahupowerdns
Member

ahupowerdns commented May 28, 2017

Short description

LuaJIT 2.1 betas provide functionality we did not expect for "Lua 5.1", so we added our own 5.2-workalike in the luaL_* namespace. This collided with LuaJIT 2.1 beta. We now no longer use that namespace. Note that we use luaL_setfunction in one other place, but we don't create a new function there, so there is no problem.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

ahupowerdns added some commits May 28, 2017

we guess which versions of Lua need help with luaL_setfuncs, and then…
… supply our own. If we guess wrong however, we trample on the Lua namespace.

With this commit, we don't do the trampling, which should close #5348. We can improve on the fix by using the native luaL_setfuncs for LuaJIT 2.1 beta too.

@rgacogne rgacogne added this to the auth-4.1.0 milestone May 29, 2017

@ahupowerdns ahupowerdns merged commit 5c3f524 into PowerDNS:master May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment