Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Get rid of std::move() calls preventing copy elision #5359

Merged
merged 1 commit into from Jun 1, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 1, 2017

Short description

We were basically betting on the compiler not doing copy elision, and thus moving the temporary value which effectively prevented him from doing so. Let's just assume that the compiler will do its job.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jun 1, 2017
@pieterlexis pieterlexis merged commit b97cc81 into PowerDNS:master Jun 1, 2017
1 check passed
@rgacogne rgacogne deleted the dnsdist-no-useless-moves branch Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants