Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix RecordsTypeCountRule's handling of the # of records in a section #5369

Merged
merged 1 commit into from Jun 19, 2017
Merged

dnsdist: Fix RecordsTypeCountRule's handling of the # of records in a section #5369

merged 1 commit into from Jun 19, 2017

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 2, 2017

Short description

We can bail out if the section has less records than the minimum we require, but not if it has more since they obviously might be of different types.

Fixes #5365.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jun 2, 2017
@rgacogne rgacogne mentioned this pull request Jun 2, 2017
Closed
@Habbie Habbie merged commit e4a27b3 into PowerDNS:master Jun 19, 2017
@rgacogne rgacogne deleted the dnsdist-recordstypecount-max branch June 19, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.2.0
Development

Successfully merging this pull request may close these issues.

[dnsdist] RecordsTypeCountRule is broken
2 participants
@rgacogne @Habbie