Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Make a truncate action available to DynBlock and Lua #5386

merged 1 commit into from Jun 19, 2017


Copy link

@rgacogne rgacogne commented Jun 8, 2017

Short description

This allows forcing a client to retry over TCP instead of dropping or refusing the query.


I have:

  • read the document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link

@ahupowerdns ahupowerdns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the way it should. However, did you not also do a PR that allowed for generic actions to be run in a Dynamic context? Is this in addition to that?

Copy link
Member Author

Yes, this is indeed in addition to the previous PR allowing other actions in a dynamic context than just dropping the query. For now only selected actions are available in that context though, but should the need arises we could add support for almost all existing actions.

@Habbie Habbie merged commit 98356ba into PowerDNS:master Jun 19, 2017
@rgacogne rgacogne deleted the dnsdist-action-truncate branch June 19, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants