New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Make more specific Netmasks < to less specific ones #5406

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@rgacogne
Member

rgacogne commented Jun 14, 2017

Short description

Having the most specific ones first, then the less specific ones then the empty one makes it easier to match the most specific first, in that case in the cache.

Please don't merge before we ponder the impact of this change a bit more!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Jun 14, 2017

@rgacogne rgacogne referenced this pull request Jun 15, 2017

Merged

rec40: Backport ECS fixes #5415

3 of 7 tasks complete
@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jun 19, 2017

Member

PR is conflicted

Member

Habbie commented Jun 19, 2017

PR is conflicted

rec: Make more specific Netmask < to less specific ones
Having the most specific ones first, then the less specific ones
then the empty one makes it easier to match the most specific first.

@pieterlexis pieterlexis merged commit 6fa4887 into PowerDNS:master Jul 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-netmask-ordering branch Jul 18, 2017

@rgacogne rgacogne referenced this pull request Jul 18, 2017

Merged

rec: Fix the recursor build #5530

3 of 6 tasks complete

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment