New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when making a netmask from a comboaddress, we neglected to zero the port #5408

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@ahupowerdns
Member

ahupowerdns commented Jun 15, 2017

when making a netmask from a comboaddress, we neglected to zero the port. This could lead to a proliferation of netmasks when compared naively (the port could be random!)

Short description

Hardcode the port of a netmask to 0. It really should not HAVE a port, but this does speed up "conversion".

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
when making a netmask from a comboaddress, we neglected to zero the p…
…ort. This could lead to a proliferation of netmasks.

@ahupowerdns ahupowerdns added the rec label Jun 15, 2017

@ahupowerdns ahupowerdns requested a review from rgacogne Jun 15, 2017

@rgacogne rgacogne merged commit f6983c5 into PowerDNS:master Jun 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne referenced this pull request Jun 15, 2017

Merged

rec40: Backport ECS fixes #5415

3 of 7 tasks complete

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment