dnsdist: Fix TCP with Fast Open requested but unsupported #5454
Conversation
If `tcpFastOpen` is set on a backend, we used to skip the `connect()` call regardless of `MSG_FASTOPEN` availability. We then tried to call `sendmsg()` (without `MSG_FASTOPEN`) on an unconnected TCP socket, which failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
If
tcpFastOpen
is set on a backend, we used to skip theconnect()
call regardless ofMSG_FASTOPEN
availability. We then tried to callsendmsg()
(withoutMSG_FASTOPEN
) on an unconnected TCP socket, which failed.Fixes #5452.
Checklist
I have: