Skip to content

/ pdns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix TCP with Fast Open requested but unsupported #5454

Merged
merged 1 commit into from Jun 27, 2017
Merged

dnsdist: Fix TCP with Fast Open requested but unsupported #5454

merged 1 commit into from Jun 27, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 23, 2017

Short description

If tcpFastOpen is set on a backend, we used to skip the connect() call regardless of MSG_FASTOPEN availability. We then tried to call sendmsg() (without MSG_FASTOPEN) on an unconnected TCP socket, which failed.

Fixes #5452.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne
dnsdist: Fix TCP with Fast Open requested but unsupported
Loading status checks…
d987f63 
If `tcpFastOpen` is set on a backend, we used to skip the
`connect()` call regardless of `MSG_FASTOPEN` availability.
We then tried to call `sendmsg()` (without `MSG_FASTOPEN`)
on an unconnected TCP socket, which failed.
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jun 23, 2017
@rgacogne rgacogne mentioned this pull request Jun 23, 2017
Closed
@pieterlexis pieterlexis merged commit df877d5 into PowerDNS:master Jun 27, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-tcp-fastopen-not-available branch Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.2.0
Linked issues

Successfully merging this pull request may close these issues.

TCP communication error when tcpFastOpen=true
2 participants
@rgacogne @pieterlexis