New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Lua Policy Engine code #5468

Merged
merged 5 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@cmouse
Contributor

cmouse commented Jun 26, 2017

Short description

As per discussion with @Habbie, this request drops all code and tests related to LPE.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the auth label Jun 26, 2017

@rgacogne rgacogne added this to the auth-4.1.0 milestone Jun 26, 2017

@cmouse cmouse referenced this pull request Jun 27, 2017

Merged

Remove old Lua code #5390

5 of 6 tasks complete
@Habbie

Habbie approved these changes Jul 6, 2017

Two nits. doc nit needs to be resolved. Otherwise approved.

Show outdated Hide outdated docs/WIP/luapolicy.xml Outdated
Show outdated Hide outdated pdns/dnspacket.cc Outdated
@cmouse

This comment has been minimized.

Show comment
Hide comment
@cmouse

cmouse Jul 7, 2017

Contributor

nits fixed.

Contributor

cmouse commented Jul 7, 2017

nits fixed.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jul 7, 2017

Member

Sorry, when I asked to mention dnsdist in the docs, I did not realise this feature never even made it to the actual docs. Can you drop the xml completely, and put a note in the auth upgrade notes instead? Thanks!

Member

Habbie commented Jul 7, 2017

Sorry, when I asked to mention dnsdist in the docs, I did not realise this feature never even made it to the actual docs. Can you drop the xml completely, and put a note in the auth upgrade notes instead? Thanks!

docs: Drop unused documentation
This never was actually used anywhere, so it's
safe to drop.
@cmouse

This comment has been minimized.

Show comment
Hide comment
@cmouse

cmouse Jul 7, 2017

Contributor

done

Contributor

cmouse commented Jul 7, 2017

done

@Habbie

Habbie approved these changes Jul 7, 2017

@Habbie Habbie merged commit 4a59230 into PowerDNS:master Jul 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Habbie Habbie referenced this pull request Aug 24, 2017

Closed

[WIP] fix root zone denials #5651

1 of 7 tasks complete

@Habbie Habbie referenced this pull request Aug 15, 2018

Merged

remove unused policy script #6854

0 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment