Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix TCP short writes handling #5501

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 6, 2017

Short description

Fix a bug in the handling of short writes over TCP. It could have led to sending data from the beginning of the buffer twice instead of from the proper place in the buffer, sending corrupted responses.
Since it requires filling out the TCP window, and thus large answers toward the same TCP client to occur, AXFR answers are the most likely to be affected.
Introduced in #4985, so only master is affected.

Fixes #5494.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@ahupowerdns ahupowerdns merged commit 49873bd into PowerDNS:master Jul 6, 2017
@rgacogne rgacogne deleted the dnsdist-tcp-short-writes branch July 7, 2017 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gmysql backend, dig axfr results in "Got bad packet: bad label type"
2 participants