New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix TCP short writes handling #5501

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jul 6, 2017

Short description

Fix a bug in the handling of short writes over TCP. It could have led to sending data from the beginning of the buffer twice instead of from the proper place in the buffer, sending corrupted responses.
Since it requires filling out the TCP window, and thus large answers toward the same TCP client to occur, AXFR answers are the most likely to be affected.
Introduced in #4985, so only master is affected.

Fixes #5494.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jul 6, 2017

@ahupowerdns ahupowerdns merged commit 49873bd into PowerDNS:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-tcp-short-writes branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment