dnsdist: Fix TCP short writes handling #5501
Merged
Conversation
de8465f
to
d944296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
Fix a bug in the handling of short writes over
TCP
. It could have led to sending data from the beginning of the buffer twice instead of from the proper place in the buffer, sending corrupted responses.Since it requires filling out the
TCP
window, and thus large answers toward the sameTCP
client to occur,AXFR
answers are the most likely to be affected.Introduced in #4985, so only master is affected.
Fixes #5494.
Checklist
I have: