New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to recursor cache dumps #5511

Merged
merged 4 commits into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Jul 10, 2017

Short description

This change will dump RRSIGs for the recursor cache, negative cache.

It also adds the validation state to the dump.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne

Looks good. I wonder why we felt the need to catch exceptions during the dump in the positive cache but not in the negative one but that's not your doing.

@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Jul 10, 2017

Member

I think that is (was) there when empty DNSNames were breaking things?

Member

pieterlexis commented Jul 10, 2017

I think that is (was) there when empty DNSNames were breaking things?

@rgacogne rgacogne merged commit bdd70ab into PowerDNS:master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:dump-cache-updates branch Jul 17, 2017

rgacogne added a commit that referenced this pull request Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment