New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DNSPacket from getAuth() signature #5516

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@zeha
Collaborator

zeha commented Jul 12, 2017

Short description

The original motivation for #4545: avoid creating fake DNSPacket objects just for calling getAuth() from API code.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@zeha zeha added the auth label Jul 12, 2017

@zeha zeha requested a review from Habbie Jul 12, 2017

@mind04

mind04 approved these changes Jul 13, 2017

@rgacogne rgacogne added this to the auth-4.1.0 milestone Jul 13, 2017

@pieterlexis pieterlexis merged commit 77b043d into PowerDNS:master Jul 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:getauth-no-dnspacket branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment