New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Fix validation at the exact RRSIG inception or expiration time #5525

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Jul 17, 2017

Short description

rfc4035 states that:

  • The validator's notion of the current time MUST be less than or equal to the time listed in the RRSIG RR's Expiration field.

  • The validator's notion of the current time MUST be greater than or equal to the time listed in the RRSIG RR's Inception field.

Reported by Petr Špaček of cz.nic (thanks!).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Fix validation at the exact RRSIG inception or expiration time
Reported by Petr Špaček of cz.nic (thanks!).

@rgacogne rgacogne added this to the rec-4.1.0 milestone Jul 17, 2017

@pieterlexis pieterlexis merged commit 3d9ab88 into PowerDNS:master Jul 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-sign-inception branch Jul 18, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment