Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Deprecate syntactic sugar functions in 1.2.0 #5526

Merged
merged 2 commits into from Aug 14, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 17, 2017

Short description

Deprecate syntactic sugar functions in 1.2.0 for removal at a later time:

  • addAnyTCRule
  • addDomainBlock
  • addDomainSpoof
  • addDomainCNAMESpoof
  • addPoolRule
  • addNoRecurseRule
  • addDisableValidationRule
  • addQPSPoolRule
  • setDNSSECPool
  • addQPSLimit
  • addDelay

Don't merge yet, at the very least I need to update the new docs!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added the dnsdist label Jul 17, 2017
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jul 17, 2017
Deprecates:
 * addAnyTCRule
 * addDomainBlock
 * addDomainSpoof
 * addDomainCNAMESpoof
 * addPoolRule
 * addNoRecurseRule
 * addDisableValidationRule
 * addQPSPoolRule
 * setDNSSECPool
 * addQPSLimit
 * addDelay
@rgacogne rgacogne force-pushed the rgacogne:dnsdist-deprecate branch from 1533fe6 to 832c179 Aug 3, 2017
@rgacogne rgacogne changed the title [WIP] dnsdist: Deprecate syntactic sugar functions in 1.2.0 dnsdist: Deprecate syntactic sugar functions in 1.2.0 Aug 3, 2017
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Aug 3, 2017

Updated to the new documentation format.

@rgacogne rgacogne requested a review from pieterlexis Aug 11, 2017
Copy link
Member

@pieterlexis pieterlexis left a comment

Looks good, really nice that we warn about the deprecations on add.


:param string domain: The domain name to block

.. function:: addDomainSpoof(domain, IPv4[, IPv6])
addDomainSpoof(domain, {IP[,...]})

.. deprecated:: 1.2.0

This comment has been minimized.

@pieterlexis

pieterlexis Aug 14, 2017
Member

All these deprecated things could have the line "Will be removed in 1.3.0" in there as well?

This comment has been minimized.

@rgacogne

rgacogne Aug 14, 2017
Author Member

Yes, but I don't want to commit on doing the actual removal in 1.3.0 :)

This comment has been minimized.

@rgacogne

rgacogne Aug 14, 2017
Author Member

Oh, I did in the warning messages when a rule is added, so it's not consistent. I guess I'll add the proposed line then!

…1.3.0
@rgacogne rgacogne force-pushed the rgacogne:dnsdist-deprecate branch from 02515d3 to 7488f98 Aug 14, 2017
@rgacogne rgacogne merged commit a650881 into PowerDNS:master Aug 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-deprecate branch Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.