New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Be more careful about the validation of negative answers #5570

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Aug 1, 2017

Short description

We skipped the validation of:

  • ECS-specific negative answers
  • completely empty NODATA answers (no SOA, no NSEC, nothing)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Be more careful about the validation of negative answers
We skipped the validation of:
- ECS-specific negative answers
- completely empty NODATA answers (no SOA, no NSEC, nothing)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Aug 1, 2017

@rgacogne rgacogne merged commit c387e39 into PowerDNS:master Aug 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-neg-validation branch Aug 10, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Aug 10, 2017

rgacogne added a commit that referenced this pull request Aug 10, 2017

Merge pull request #5592 from rgacogne/rec-fix-syncres-unit-tests
rec: Fix the tests added in #5569 and #5570, DNSSEC modes changed in #5557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment