New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Document the tag features #5577

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Aug 3, 2017

Short description

Document the new features introduced in #5396.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Aug 3, 2017

@@ -84,6 +84,48 @@ It also supports the following methods:
:returns: true if the DO bit was set, false otherwise
.. classmethod:: DNSQuestion.getTag(key) -> string

This comment has been minimized.

@pieterlexis

pieterlexis Aug 9, 2017

Member

Shouldn't this be DNSQuestion:getTag(key) (also for the other newly added functions?)

This comment has been minimized.

@rgacogne

rgacogne Aug 9, 2017

Member

Indeed it should, I blindly copied the DNSQuestion.getDO() typo above. I'll fix it, thanks!

This comment has been minimized.

@rgacogne

rgacogne Aug 11, 2017

Member

Fixed!

@rgacogne rgacogne force-pushed the rgacogne:dist-doc-tags branch from 302bc7c to ab6f6ac Aug 9, 2017

@rgacogne rgacogne merged commit 53ce163 into PowerDNS:master Aug 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dist-doc-tags branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment