dnsdist: Don't use square brackets for IPv6 in Carbon metrics #5579
Conversation
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
Use
2001:db8::1:53_tcp
instead of[2001:db8::1]:53_tcp
, as square brackets have special meaning for some Carbon storage engines and backends. I went with the:port
instead of_port
as suggested in the initial report to be consistent with the current IPv4 encoding. Since the port is always present it shouldn't be ambiguous, but I'm of course open to switch to another encoding.Fixes #5538.
Checklist
I have: