Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Don't use square brackets for IPv6 in Carbon metrics #5579
Conversation
rgacogne
added
the
dnsdist
label
Aug 3, 2017
rgacogne
added this to the dnsdist-1.2.0 milestone
Aug 3, 2017
This comment has been minimized.
This comment has been minimized.
|
lgtm! |
rgacogne
merged commit 1401e76
into
PowerDNS:master
Aug 14, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:dnsdist-carbon-ip
branch
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedAug 3, 2017
Short description
Use
2001:db8::1:53_tcpinstead of[2001:db8::1]:53_tcp, as square brackets have special meaning for some Carbon storage engines and backends. I went with the:portinstead of_portas suggested in the initial report to be consistent with the current IPv4 encoding. Since the port is always present it shouldn't be ambiguous, but I'm of course open to switch to another encoding.Fixes #5538.
Checklist
I have: