New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Don't use square brackets for IPv6 in Carbon metrics #5579

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Aug 3, 2017

Short description

Use 2001:db8::1:53_tcp instead of [2001:db8::1]:53_tcp, as square brackets have special meaning for some Carbon storage engines and backends. I went with the :port instead of _port as suggested in the initial report to be consistent with the current IPv4 encoding. Since the port is always present it shouldn't be ambiguous, but I'm of course open to switch to another encoding.

Fixes #5538.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the dnsdist label Aug 3, 2017

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Aug 3, 2017

@pieterlexis

This comment has been minimized.

Member

pieterlexis commented Aug 14, 2017

lgtm!

@rgacogne rgacogne merged commit 1401e76 into PowerDNS:master Aug 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-carbon-ip branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment