Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Copy the DNS header before encrypting it in place #5580
Conversation
rgacogne
added
defect
dnsdist
labels
Aug 4, 2017
rgacogne
added this to the dnsdist-1.2.0 milestone
Aug 4, 2017
This comment has been minimized.
This comment has been minimized.
bjoe2k4
commented
Aug 10, 2017
|
Works for me. No Err#14 anymore. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@bjoe2k4 Thank you for reporting, testing and confirming! |
rgacogne
merged commit 286b8fa
into
PowerDNS:master
Aug 10, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:ddist-dnscrypt-ringbuffer-dnsheader
branch
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedAug 4, 2017
Short description
When DNSCrypt is enabled, we encrypt the answer in place, but we need to keep a copy of the DNS header of the original answer to be able to populate the responses ring buffer.
Fixes #5566.
Checklist
I have: