New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Copy the DNS header before encrypting it in place #5580

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Aug 4, 2017

Short description

When DNSCrypt is enabled, we encrypt the answer in place, but we need to keep a copy of the DNS header of the original answer to be able to populate the responses ring buffer.

Fixes #5566.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
dnsdist: Copy the DNS header before encrypting it in place
When DNSCrypt is enabled, we encrypt the answer in place, but we
need to keep a copy of the DNS header of the original answer to
be able to populate the responses ring buffer.

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Aug 4, 2017

@bjoe2k4

This comment has been minimized.

bjoe2k4 commented Aug 10, 2017

Works for me. No Err#14 anymore. Thanks!

@rgacogne

This comment has been minimized.

Member

rgacogne commented Aug 10, 2017

@bjoe2k4 Thank you for reporting, testing and confirming!

@rgacogne rgacogne merged commit 286b8fa into PowerDNS:master Aug 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:ddist-dnscrypt-ringbuffer-dnsheader branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment