New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listen on 127.0.0.1 during regression tests #5583

Merged
merged 2 commits into from Aug 23, 2017

Conversation

Projects
None yet
4 participants
@tcely
Contributor

tcely commented Aug 6, 2017

Short description

Added an address variable to regression-tests set to 127.0.0.1

Issue #2835

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the auth-4.1.0 milestone Aug 7, 2017

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 9, 2017

Member

Do you think you can add an easy way to override this? An environment variable from outside perhaps?

Member

Habbie commented Aug 9, 2017

Do you think you can add an easy way to override this? An environment variable from outside perhaps?

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 14, 2017

Member

Hmm, this does not actually address #2835 as for v6 we still listen on :: with this.

Member

Habbie commented Aug 14, 2017

Hmm, this does not actually address #2835 as for v6 we still listen on :: with this.

@tcely

This comment has been minimized.

Show comment
Hide comment
@tcely

tcely Aug 14, 2017

Contributor

I didn't see IPv6 mentioned in that issue, but we could always include --local-ipv6=::1 if that would be desirable.

At this point though, I'd suggest a common flags file that these backend files all include instead of environment variables.

Contributor

tcely commented Aug 14, 2017

I didn't see IPv6 mentioned in that issue, but we could always include --local-ipv6=::1 if that would be desirable.

At this point though, I'd suggest a common flags file that these backend files all include instead of environment variables.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 14, 2017

Member

No, I only noticed v6 being an issue when I tested your patch. I agree on all this duplication being bad. I'm happy merging this as is and updating the ticket so somebody can go deeper when they have time.

Member

Habbie commented Aug 14, 2017

No, I only noticed v6 being an issue when I tested your patch. I agree on all this duplication being bad. I'm happy merging this as is and updating the ticket so somebody can go deeper when they have time.

@aerique aerique merged commit 9a0577e into PowerDNS:master Aug 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tcely tcely deleted the tcely:issue-2835 branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment