New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldapbackend: Add support for new record types #5584

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@eehakkin
Contributor

eehakkin commented Aug 6, 2017

Short description

Add support for some new record types to the LDAP backend.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the auth-4.1.0 milestone Aug 7, 2017

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 9, 2017

Member

@goestreicher any comments? looks good to me i think

Member

Habbie commented Aug 9, 2017

@goestreicher any comments? looks good to me i think

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 28, 2017

Member

Reviewed, looks good. Can you add a note to https://github.com/PowerDNS/pdns/blob/master/docs/upgrading.rst#40x-to-410 ? Then this is ready for merge.

Member

Habbie commented Aug 28, 2017

Reviewed, looks good. Can you add a note to https://github.com/PowerDNS/pdns/blob/master/docs/upgrading.rst#40x-to-410 ? Then this is ready for merge.

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Sep 11, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Sep 11, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Sep 12, 2017

@aerique aerique requested a review from Habbie Sep 13, 2017

@aerique

This comment has been minimized.

Show comment
Hide comment
@aerique

aerique Sep 13, 2017

Member

#5666 has been merged into master for the required docs.

Member

aerique commented Sep 13, 2017

#5666 has been merged into master for the required docs.

@aerique aerique merged commit 2834c50 into PowerDNS:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aerique aerique removed the request for review from Habbie Sep 13, 2017

@eehakkin eehakkin deleted the eehakkin:ldapbackend/new-record-types branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment