New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the default webserver's ACL to "127.0.0.1, ::1" #5588

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Aug 9, 2017

Short description

The default value of webserver-allow-from (0.0.0.0, ::/0) means that the webserver is accessible from everywhere as soon as it's enabled. We don't want to change that in a minor release, but let's switch to a more sensible default (127.0.0.1, ::1) for 4.1.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha

zeha approved these changes Aug 9, 2017

@pieterlexis

One nit in the docs

Show outdated Hide outdated pdns/recursordist/docs/settings.rst
@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Aug 11, 2017

Member

also here 😄

Member

pieterlexis commented Aug 11, 2017

also here 😄

@rgacogne

This comment has been minimized.

Show comment
Hide comment
@rgacogne

rgacogne Aug 11, 2017

Member

done!

Member

rgacogne commented Aug 11, 2017

done!

@rgacogne rgacogne merged commit 1ee5976 into PowerDNS:master Aug 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:webserver-doc-acls branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment