dnsdist: Fix several signed/unsigned comparison warnings on ARM #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would lead to signed/unsigned comparison warnings on ARM.
rgacogne
reviewed
Aug 11, 2017
pdns/dnsdist-tcp.cc
Outdated
| @@ -190,7 +190,7 @@ static bool sendResponseToClient(int fd, const char* response, uint16_t response | |||
| static bool maxConnectionDurationReached(unsigned int maxConnectionDuration, time_t start, unsigned int& remainingTime) | |||
| { | |||
| if (maxConnectionDuration) { | |||
| time_t elapsed = time(NULL) - start; | |||
| unsigned int elapsed = time(NULL) - start; | |||
There was a problem hiding this comment.
It probably doesn't matter much but this would lead to closing the connection right away if the time goes backward, because then elapsed becomes huge instead of negative. Perhaps we should store time(nullptr), and if it's lesser than start set elapsed to 0.
pieterlexis
force-pushed
the
dnsdist-signed-unsigned-arm
branch
from
2dbfb92 to
0b75a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Closes #5489
Checklist
I have: