New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTIMP is only appropriate for an unsupported opcode #5611

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@mind04
Contributor

mind04 commented Aug 14, 2017

Short description

In rfc1035 is not very clear about this
4.1.1

OPCODE          A four bit field that specifies kind of query in this
                message. ...

and

                4               Not Implemented - The name server does
                                not support the requested kind of query.

But there is room for discussion.

rfc2136 on the other hand, is very clear about the use of NOTIMP
2.2

              NOTIMP      4       The name server does not support
                                  the specified Opcode.

This pull is replacing NOTIMP with REFUSED for non opcode related use.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the auth label Aug 14, 2017

@rgacogne rgacogne added this to the auth-4.1.0 milestone Aug 14, 2017

@Habbie

Habbie approved these changes Aug 14, 2017

@Habbie Habbie merged commit 71c749d into PowerDNS:master Aug 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mind04 mind04 deleted the mind04:notimp branch Aug 21, 2017

@aerique aerique added the enhancement label Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment