New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in logging of dnssec validation, add some fields #5614

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Aug 14, 2017

Short description

Fix some typos in DNSSEC debug logging, add some more data

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
ne.d_validationState = Insecure;
}
if (res == NXDOMAIN && expectedState == NXQTYPE) {
/* might happen for empty non-terminal, have fun */
return;
}
else {
LOG(d_prefix<<"Invalid denial found for "<<ne.d_name<<", retuning Bogus"<<endl);
LOG(d_prefix<<"Invalid denial found for "<<ne.d_name<<", returning Bogus, res="<<res<<", expectedState="<<expectedState<<endl);

This comment has been minimized.

@rgacogne

rgacogne Aug 15, 2017

Member

It might be nicer to use the textual representation of the denial states instead of the numerical one here:

LOG(d_prefix<<"Invalid denial found for "<<ne.d_name<<", returning Bogus, res="<<dStates[res]<<", expectedState="<<dStates[expectedState]<<endl

@rgacogne

rgacogne Aug 15, 2017

Member

It might be nicer to use the textual representation of the denial states instead of the numerical one here:

LOG(d_prefix<<"Invalid denial found for "<<ne.d_name<<", returning Bogus, res="<<dStates[res]<<", expectedState="<<dStates[expectedState]<<endl

@rgacogne rgacogne added this to the rec-4.1.0 milestone Aug 15, 2017

@ahupowerdns ahupowerdns merged commit fdb2cfd into PowerDNS:master Aug 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment