New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for deleting entries in NetmaskTree and NetmaskGroup #5616

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Aug 15, 2017

Short description

  • NetmaskTree::erase() now removes "hanging" branches of the tree, if the cleanup constructor parameter was set to true
  • NetmaskGroup now has deleteMask() methods that use NetmaskTree:erase()
  • NetmaskGroup gained lookup() methods in the process

Grabbed from the weakforced tree:

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Better support for deleting entries in NetmaskTree and NetmaskGroup
- NetmaskTree erase() method now has optional cleanup parameter
  - cleanup_tree() method will remove "hanging" branches of the tree
- NetmaskGroup now has deleteMask() methods that use NetmaskTree:erase()

Grabbed from the weakforced tree:
- PowerDNS/weakforced@d5c916a
- PowerDNS/weakforced@1170d8d

@pieterlexis pieterlexis merged commit f3df1f6 into PowerDNS:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:nmt-cleanup-from-weakforced branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment