New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Log the policy type (QName, Client IP, NS IP...) over protobuf #5621

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Aug 17, 2017

Short description

Add a new field to our protocol buffer format to be able to know which type of policy matched. This is especially useful when using one or more RPZ zone containing different types of rules.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Aug 17, 2017

@@ -66,6 +66,21 @@ def printQuery(self, message):
message.question.qType,
message.question.qName))
@staticmethod
def getAppliedPolicyTypeAsString(polType):
if polType == dnsmessage_pb2.PBDNSMessage.UNKNOWN:

This comment has been minimized.

@Habbie

Habbie Aug 23, 2017

Member

Would a dict lookup make more sense here?

@Habbie

Habbie Aug 23, 2017

Member

Would a dict lookup make more sense here?

@aerique aerique merged commit d650487 into PowerDNS:master Aug 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-protobuf-rpz-type branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment