Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix potential pointer wrap-around on 32 bits #5630

Merged
merged 1 commit into from Aug 21, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 21, 2017

Short description

This can lead to a DoS on 32 bits if a backend server sends a crafted response and we happen to be working with a buffer allocated to a very high virtual address.

Reported by Guido Vranken (many thanks!).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
This can lead to a DoS on 32 bits if a backend server sends a
crafted response and we happen to be working with a buffer allocated to
a very high virtual address.

Reported by Guido Vranken (many thanks!).
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Aug 21, 2017
@rgacogne rgacogne merged commit 1c90ce3 into PowerDNS:master Aug 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-h1-168297 branch Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant