New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused SortList compare operator for ComboAddress #5637

Merged
merged 2 commits into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@Habbie
Member

Habbie commented Aug 21, 2017

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added the rec label Aug 22, 2017

@rgacogne rgacogne added this to the rec-4.1.0 milestone Aug 22, 2017

@rgacogne

This comment has been minimized.

Show comment
Hide comment
@rgacogne

rgacogne Aug 22, 2017

Member

It looks like there is also an unused extern SortList g_sortlist; in pdns_recursor.cc that should go, but that can be done in a separate PR.

Member

rgacogne commented Aug 22, 2017

It looks like there is also an unused extern SortList g_sortlist; in pdns_recursor.cc that should go, but that can be done in a separate PR.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Aug 23, 2017

Member

It looks like there is also an unused extern SortList g_sortlist; in pdns_recursor.cc that should go, but that can be done in a separate PR.

pushed

Member

Habbie commented Aug 23, 2017

It looks like there is also an unused extern SortList g_sortlist; in pdns_recursor.cc that should go, but that can be done in a separate PR.

pushed

@aerique aerique merged commit 924d1e9 into PowerDNS:master Aug 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment