New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Add NSEC records on nx-trust cache hits #5672

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Sep 6, 2017

Short description

We forgot to add NSEC/NSEC3 records on a root-nx-trust cache hit.
Fixes #5649.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Sep 6, 2017

@aerique aerique requested a review from Habbie Sep 11, 2017

@Habbie

Habbie approved these changes Sep 12, 2017

Code looks good. Code also works!

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Sep 12, 2017

Member

A test might be nice at some point though.

Member

Habbie commented Sep 12, 2017

A test might be nice at some point though.

@aerique aerique merged commit 5b107e2 into PowerDNS:master Sep 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-nxtrust-denial-nsec branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment