New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Treat requestor's payload size lower than 512 as equal to 512 #5678

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Sep 8, 2017

Short description

rfc6891 states in section 6.2.3 that:

[a requestor's payload] lower than 512 MUST be treated as equal to 512

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the auth-4.1.0 milestone Sep 8, 2017

@rgacogne rgacogne requested review from Habbie and pieterlexis Sep 13, 2017

@pieterlexis

👍 , could use a unit test?

@aerique aerique merged commit 1519c8d into PowerDNS:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:auth-requestor-payload branch Sep 13, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment