New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more specific about trailing dot handling, fixes #5673 #5684

Merged
merged 3 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@Habbie
Member

Habbie commented Sep 11, 2017

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.1.0 milestone Sep 11, 2017

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Sep 11, 2017

Member

This is ready for review but I'm planning to add a test. The test itself is not an auth 4.1 blocker so merge away after review.

Member

Habbie commented Sep 11, 2017

This is ready for review but I'm planning to add a test. The test itself is not an auth 4.1 blocker so merge away after review.

Show outdated Hide outdated pdns/dnsrecords.cc Outdated
Show outdated Hide outdated pdns/dnsrecords.cc Outdated
@rgacogne

Looks good to me!

@aerique aerique merged commit 675a4ca into PowerDNS:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment