Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add missing QPSAction #5686

merged 1 commit into from Oct 23, 2017


Copy link

@rgacogne rgacogne commented Sep 13, 2017

Short description

In 1.2.0 we deprecated the addQPSLimit() function, suggesting the use of QPSAction() as a replacement, but the Lua binding for QPSAction() was missing. In addition the documentation was referring to QPSLimitAction() instead of QPSAction().


I have:

  • read the document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
In 1.2.0 we deprecated the `addQPSLimit()` function, suggesting the
use of `QPSAction()` as a replacement, but the Lua binding for
`QPSAction()` was missing. In addition the documenration was referring
to `QPSLimitAction()` instead of `QPSAction()`.
@rgacogne rgacogne added this to the dnsdist-1.2.x milestone Sep 13, 2017
@rgacogne rgacogne merged commit 3444abc into PowerDNS:master Oct 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@rgacogne rgacogne deleted the rgacogne:dnsdist-qps-action branch Oct 23, 2017
rgacogne added a commit to rgacogne/pdns that referenced this pull request Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant