New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth DNSSEC: Make default options singular and use defaults in Cryptokey API-endpoint #5704

Merged
merged 4 commits into from Sep 22, 2017

Conversation

Projects
None yet
5 participants
@pieterlexis
Member

pieterlexis commented Sep 18, 2017

Short description

Before, the default-{k,z}sk-algorithms options would accept multiple options. While the default-{k,z}sk-size would only accept a single value.

The first commit makes the algorithms options singular.

Furthermore, size is only needed for non-fixed length algo's (and we don't have defaults). the second displays a warning on start up if the size is 0 when it should be a number.

The last commit makes the cryptokey endpoint in the API use the defaults if algo and/or size are not passed in the request.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis added this to the auth-4.1.0 milestone Sep 18, 2017

@pieterlexis pieterlexis requested review from zeha and Habbie Sep 18, 2017

Show outdated Hide outdated docs/http-api/endpoint-cryptokeys.rst Outdated
@Habbie

Habbie approved these changes Sep 19, 2017

approved with nits

Show outdated Hide outdated docs/settings.rst Outdated
Show outdated Hide outdated docs/settings.rst Outdated
Show outdated Hide outdated docs/settings.rst Outdated
Show outdated Hide outdated pdns/common_startup.cc Outdated
Show outdated Hide outdated pdns/common_startup.cc Outdated
@zeha

zeha approved these changes Sep 22, 2017

API bits LGTM

@pieterlexis pieterlexis merged commit 8a3bc8f into PowerDNS:master Sep 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:api-cryptokey-use-defaults branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment