New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Use a unique pointer for bind backend's `d_of` #5723

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Sep 22, 2017

Short description

While this should not happen, using a smart pointer prevents double-free, user-after-free or invalid pointer dereference if we mess up our transaction logic.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the auth-4.1.0 milestone Sep 22, 2017

@aerique aerique requested a review from Habbie Sep 26, 2017

@Habbie

Habbie approved these changes Sep 27, 2017

@aerique aerique merged commit 26b7516 into PowerDNS:master Sep 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:auth-bindbackend_dof branch Sep 27, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment