New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printing of DS records from export-zone-dnskey. #5729

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@aerique
Member

aerique commented Sep 25, 2017

Short description

Remove printing of DS records from pdnsutil export-zone-dnskey …. This was not only inconsistent behaviour[1] but also done incorrectly[2].

Fixes #5719.

[1] as noted by @jpmens
[2] as noted by @Habbie

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@aerique aerique added this to the auth-4.1.0 milestone Sep 25, 2017

@aerique aerique self-assigned this Sep 25, 2017

@aerique aerique requested review from jpmens, Habbie and rgacogne Sep 25, 2017

@jpmens

This comment has been minimized.

Show comment
Hide comment
@jpmens

jpmens Sep 25, 2017

Contributor

As far as I can tell, removal of the DS printing looks ok. ;)

Contributor

jpmens commented Sep 25, 2017

As far as I can tell, removal of the DS printing looks ok. ;)

@aerique aerique merged commit 9249151 into PowerDNS:master Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment