New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for AFSDB fix (PR #5667) #5730

Merged
merged 3 commits into from Sep 25, 2017

Conversation

Projects
None yet
4 participants
@aerique
Member

aerique commented Sep 25, 2017

Short description

This adds the requested unit test to PR #5667.

Question for reviewers: in the unit test only check for QType and content or keeps all checks?

Closes #5667.
Closes #4703.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
    • both before and after the fix (so before the new unit test fails and after it passes)
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

ArmedGuy added some commits Sep 5, 2017

Handle AFSDB record separately due to record structure.
Closes #4703.

AFSDB records has two elements, <subtype> <hostname>,
as per RFC1183, and needs special treatment when parsing.

@aerique aerique added this to the auth-4.1.0 milestone Sep 25, 2017

@aerique aerique self-assigned this Sep 25, 2017

@Habbie

Also, please correct the typo in the PR title :)

Show outdated Hide outdated modules/remotebackend/test-remotebackend.cc Outdated

@aerique aerique changed the title from Unit test for ASFDB fix (PR #5667) to Unit test for AFSDB fix (PR #5667) Sep 25, 2017

@aerique aerique merged commit c461f7b into PowerDNS:master Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aerique aerique added the auth label Oct 6, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment