New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Remove pdns.PASS and pdns.TRUNCATE #5739

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Sep 27, 2017

Short description

Those values are not documented in a recursor context, and does not work as one could expect since pdns.PASS results in an immediate ServFail and pdns.TRUNCATE in a strange status code being sent (showing up as RESERVED13 in dig).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Remove pdns.PASS and pdns.TRUNCATE
Those values are not documented in a recursor context, and does not
work as expected since `pdns.PASS` resulted in an immediate `ServFail`
and `pdns.TRUNCATE` in a strange status code being sent (showing
up as `RESERVED13` in `dig`).

@rgacogne rgacogne added this to the rec-4.1.0 milestone Sep 27, 2017

@aerique aerique merged commit 7b77c18 into PowerDNS:master Sep 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-policy-pass-truncate branch Sep 28, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment