New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Lowercase all outgoing qnames when lowercase-outgoing is set #5740

Merged
merged 2 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@pieterlexis
Member

pieterlexis commented Sep 28, 2017

Short description

Before, we would only lowercase the original qname before handing it to SyncRes. Now the syncresolveWrapper lowercases if it has to before handing the qname to asyncresolve.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis requested review from rgacogne and ahupowerdns Sep 28, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Sep 28, 2017

@aerique aerique added this to the rec-4.1.x milestone Sep 28, 2017

@rgacogne

Looks good, a couple nits. On a side note the Lua hooks are now getting the original qname instead of the lowercased version, but IMHO this is actually an improvement.

Show outdated Hide outdated pdns/recursordist/test-syncres_cc.cc Outdated
Show outdated Hide outdated pdns/recursordist/test-syncres_cc.cc Outdated

pieterlexis added some commits Sep 28, 2017

Make lowercase-outgoing actually lowercase all q's
Before, we would only lowercase the original qname before handing it to
SyncRes. Now the asyncresolveWrapper lowercases if it has to behor
handing the qname to asyncresolve.

@pieterlexis pieterlexis merged commit e575780 into PowerDNS:master Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:lowercase-outgoing-all-the-things branch Oct 16, 2017

pieterlexis added a commit that referenced this pull request Oct 16, 2017

Merge pull request #5765 from pieterlexis/rec-40-lowercase-outgoing-a…
…ll-the-things

Backport #5740: Lowercase all outgoing qnames when lowercase-outgoing is set

@rgacogne rgacogne modified the milestones: rec-4.1.x, rec-4.1.0 Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment