New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dnsbulktest experience in travis for more robustness #5755

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Sep 29, 2017

This commit changes our dnsbulktest source from Alexa to Cisco Umbrella, but this turned out not to be as important as we thought.
In addition, it turns out we had been installing pdns-tools incorrectly because of wrong apt-settings. We now install pdns-tools from the master repo at repo.powerdns.com
This commit also tunes pdns_recursor to use less simultaneous outbound connections during testing, which appears to make Travis NAT happier, leading to less errors.
Finally, we use new features of dnsbulktest to extract more statistics for how well we are doing. Success is now dependent on errors and timeouts, and less on NXDOMAIN.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
Improve dnsbulktest experience in travis for more robustness
This commit changes our dnsbulktest source from Alexa to Cisco Umbrella, but this turned out not to be as important as we thought.
In addition, it turns out we had been installing pdns-tools incorrectly because of wrong apt-settings. We now install pdns-tools from the master repo at repo.powerdns.com
This commit also tunes pdns_recursor to use less simultaneous outbound connections during testing, which appears to make Travis NAT happier, leading to less errors.
Finally, we use new features of dnsbulktest to extract more statistics for how well we are doing. Success is now dependent on errors and timeouts, and less on NXDOMAIN.
@pieterlexis

2 nits, looks good otherwise. Let's see what travis thinks of it

@@ -12,7 +12,7 @@ set -x
cd regression-tests
wget -c -N https://s3.amazonaws.com/alexa-static/top-1m.csv.zip
wget -c -N http://s3-us-west-1.amazonaws.com/umbrella-static/top-1m.csv.zip

This comment has been minimized.

@pieterlexis

pieterlexis Oct 2, 2017

Member

This file is available over https.

@pieterlexis

pieterlexis Oct 2, 2017

Member

This file is available over https.

@@ -331,11 +331,11 @@ install_recursor() {
moreutils \
snmpd"
run "cd .."
run "wget https://s3.amazonaws.com/alexa-static/top-1m.csv.zip"
run "wget http://s3-us-west-1.amazonaws.com/umbrella-static/top-1m.csv.zip"

This comment has been minimized.

@pieterlexis

pieterlexis Oct 2, 2017

Member

This file is available over https.

@pieterlexis

pieterlexis Oct 2, 2017

Member

This file is available over https.

@ahupowerdns ahupowerdns merged commit 07affd0 into PowerDNS:master Oct 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rgacogne added a commit that referenced this pull request Oct 11, 2017

Merge pull request #5813 from rgacogne/rec40-backport-5755
Backport #5755: Improve dnsbulktest experience in travis for more robustness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment