New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rec: create socket-dir from init-script #5762

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Oct 3, 2017

Short description

This fixes this issue for sys v init. For systemd, it is advices that the admin creates these directories (or doesn't touch the setting).

Closes #5439

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Oct 4, 2017

Member

The escaped $-signs are needed because the initscript is generated in a heredoc

Member

pieterlexis commented Oct 4, 2017

The escaped $-signs are needed because the initscript is generated in a heredoc

@pieterlexis pieterlexis merged commit 656b3c4 into PowerDNS:master Oct 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:5439-initscript-socket-dir branch Oct 27, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment