New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep trying if the first connection to the remote logger failed #5770

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Oct 5, 2017

Short description

Instead of waiting to have a message to send and failing to send it, causing some messages to be lost in some cases because we would detect the failure too late in the process.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Keep trying if the first connection to the remote logger failed
Instead of waiting to have a message to send, causing some messages
to be lost in some cases because we would detect the failure too
late in the process.

@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Oct 5, 2017

@pieterlexis pieterlexis merged commit 1c3d532 into PowerDNS:master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:remote-logger-first-packet branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment