New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If accept() returns EAGAIN, Socket::accept() returns a null pointer #5792

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
4 participants
@rgacogne
Member

rgacogne commented Oct 9, 2017

Short description

Gracefully handle Socket::accept() returning a null pointer on EAGAIN.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Oct 9, 2017

@zeha

zeha approved these changes Oct 9, 2017

The EAGAIN handling here struck me as weird last time I looked at it, but couldnt quite point the finger on it...

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Oct 9, 2017

Member

Needs a rebase due to mongo/travis.

Member

Habbie commented Oct 9, 2017

Needs a rebase due to mongo/travis.

@aerique aerique merged commit 14bb8ca into PowerDNS:master Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:web-socket-accept-nullptr branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment