ignore SOA-EDIT for PRESIGNED zones. Fixes #5814 #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Habbie
force-pushed
the
presigned-soa-edit
branch
from
6fdc60d
to
6974c17
Compare
rgacogne
approved these changes
Oct 12, 2017
pdns/dbdnsseckeeper.cc
Outdated
| // SOA editing on a presigned zone never makes sense | ||
| return; | ||
| } | ||
|
|
||
| getFromMeta(zname, "SOA-EDIT", value); | ||
|
|
||
| if ((!soaEdit.empty() || !soaEditSigned.empty()) && value.empty() && !isPresigned(zname)) { |
There was a problem hiding this comment.
The && !isPresigned(zname) part could be removed now
There was a problem hiding this comment.
Thanks, amended & pushed.
Habbie
force-pushed
the
presigned-soa-edit
branch
from
6974c17
to
8bd6094
Compare
Habbie
force-pushed
the
presigned-soa-edit
branch
from
8bd6094
to
3ba1065
Compare
pieterlexis
added a commit
to pieterlexis/pdns
that referenced
this pull request
Nov 13, 2017
This was referenced Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Short description
When a zone is PRESIGNED, we should ignore the SOA-EDIT setting for it, as otherwise we cause the SOA signature to be bogus.
Checklist
I have: