New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore SOA-EDIT for PRESIGNED zones. Fixes #5814 #5815

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@Habbie
Member

Habbie commented Oct 12, 2017

Short description

When a zone is PRESIGNED, we should ignore the SOA-EDIT setting for it, as otherwise we cause the SOA signature to be bogus.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.1.0 milestone Oct 12, 2017

Show outdated Hide outdated pdns/dbdnsseckeeper.cc Outdated

@rgacogne rgacogne merged commit 453869f into PowerDNS:master Oct 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Habbie Habbie deleted the Habbie:presigned-soa-edit branch Oct 12, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment