Skip to content

ignore SOA-EDIT for PRESIGNED zones. Fixes #5814 #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Oct 12, 2017

Short description

When a zone is PRESIGNED, we should ignore the SOA-EDIT setting for it, as otherwise we cause the SOA signature to be bogus.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.1.0 milestone Oct 12, 2017
@Habbie Habbie force-pushed the presigned-soa-edit branch from 6fdc60d to 6974c17 Compare October 12, 2017 10:29
// SOA editing on a presigned zone never makes sense
return;
}

getFromMeta(zname, "SOA-EDIT", value);

if ((!soaEdit.empty() || !soaEditSigned.empty()) && value.empty() && !isPresigned(zname)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The && !isPresigned(zname) part could be removed now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, amended & pushed.

@Habbie Habbie force-pushed the presigned-soa-edit branch from 8bd6094 to 3ba1065 Compare October 12, 2017 14:13
@rgacogne rgacogne merged commit 453869f into PowerDNS:master Oct 12, 2017
@Habbie Habbie deleted the presigned-soa-edit branch October 12, 2017 16:06
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants