New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the issues found by @jpmens #5826

Merged
merged 4 commits into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Oct 16, 2017

Short description

This PR fixes a bunch of minor issues discovered by @jpmens (thanks!). The following issues are fixed:

  • #5787 pdnsutil set-meta will now exit with an error code if the domain does not exists
  • #5784 Two missing commands for pdnsutil (create-slave-zone and change-slave-zone-master) have been documented
  • #5786 The BIND backend will properly tell the user that they missed setting the 'file' stanza in the 'zone' block of the bind-config file
  • #5785 Clarified that the databse used for the hybrid bind mode is not the same one as the bind-dnssec-db

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis added this to the auth-4.1.0 milestone Oct 16, 2017

@pieterlexis pieterlexis requested a review from Habbie Oct 16, 2017

@pieterlexis pieterlexis merged commit 10049ae into PowerDNS:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:jpmens-issues-edition-2017 branch Oct 18, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment