New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Don't directly store NSEC3 records in the positive cache #5834

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Oct 19, 2017

Short description

We don't need to store NSEC3 records in the positive cache because:

  • we don't allow direct NSEC3 queries
  • denial of existence proofs in wildcard expanded positive responses are stored in authorityRecs for the initial qname
  • denial of existence proofs for negative responses are stored in the negative cache

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Oct 19, 2017

@aerique aerique requested review from Habbie and removed request for Habbie Oct 24, 2017

@aerique aerique merged commit 85b88ec into PowerDNS:master Oct 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-dont-cache-nsec3 branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment