Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix TeeAction() with EDNS Client Subnet #5860

Merged
merged 1 commit into from Oct 29, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 26, 2017

Short description

Since 0beaa5c we checked the space available against the current length, instead of the real capacity, resulting in the query being dropped because it looked like there was not enough room to add the ECS value.

Fixes #5859.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Since 0beaa5c we checked the space
available against the current length, instead of the real capacity,
resulting in the query being dropped because it looked like there
was not enough room to add the ECS value.
@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented Oct 26, 2017

Perhaps this needs a regression test with a receiver that catches the Tee'd traffic?

@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Oct 26, 2017

The TeeAction as a whole could use some regression tests, yes!

@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented Oct 27, 2017

Created a ticket for this: #5867

@rgacogne rgacogne merged commit 647d15b into PowerDNS:master Oct 29, 2017
1 check passed
@rgacogne rgacogne deleted the dnsdist-tee-action-fix branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants